Skip to content

feat: add spacy model download and some logs!#26

Merged
amindadgar merged 2 commits intomainfrom
fix/mediawiki-activities-wrong-arg
Apr 16, 2025
Merged

feat: add spacy model download and some logs!#26
amindadgar merged 2 commits intomainfrom
fix/mediawiki-activities-wrong-arg

Conversation

@amindadgar
Copy link
Member

@amindadgar amindadgar commented Apr 15, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores

    • Updated the Docker image to automatically download the spaCy English language model during build.

  • Enhancements

    • Improved logging in the document loading process to provide clearer runtime information and status updates.
    • Enhanced data handling to correctly reconstruct document objects before loading.

@coderabbitai
Copy link

coderabbitai bot commented Apr 15, 2025 •
edited
Loading

Walkthrough

The changes include three main updates: the Dockerfile was modified to add a step that downloads the spaCy English language model (en_core_web_sm) during the build process; the MediawikiETL.load method was enhanced with additional logging statements to report the number of documents loaded, completion of loading, and removal of the dump directory if applicable; and the load_mediawiki_data async function was updated to reconstruct Document objects from dictionaries before loading, addressing the serialization done by Temporal. No core logic or control flow was altered.

Changes

File(s) Summary of Changes
Dockerfile Added a build step to download the spaCy English language model (en_core_web_sm).
hivemind_etl/mediawiki/etl.py Added logging in MediawikiETL.load to report document count before loading, completion, and dump directory removal.
hivemind_etl/mediawiki/activities.py Modified load_mediawiki_data to reconstruct Document objects from dictionaries before loading.

Possibly related PRs

  • fix: wrong arg for MediaWikiETL! #22: Also modifies load_mediawiki_data in hivemind_etl/mediawiki/activities.py to adjust data handling before passing to MediawikiETL, adding a namespaces parameter and related constructor changes.

Poem

In Docker’s den, a model’s fetched anew,
While logs now tell us what our code will do.
Documents once lost in dict disguise,
Reborn as objects, clear and wise.
The rabbit hops, the data flows—
In every log, the progress shows!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 62ee10f and 42d5d06.

📒 Files selected for processing (1)
  • hivemind_etl/mediawiki/activities.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: ci / lint / Lint
  • GitHub Check: ci / test / Test
🔇 Additional comments (1)
hivemind_etl/mediawiki/activities.py (1)

101-103: Good fix for the object serialization issue.

The change correctly handles the serialization/deserialization process by converting the dictionary representations back to Document objects. This is necessary because Temporal serializes complex objects to dictionaries during workflow execution.

The comment clearly explains the reasoning, which helps future maintainers understand why this conversion is needed.

✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Apr 15, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
Dockerfile (1)

5-5: Consider pinning the spaCy model version for reproducibility.

The addition of the spaCy model download is correct and ensures the model is available at runtime. For more reproducible builds, consider specifying the model version explicitly (e.g., en_core_web_sm==3.7.1).

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 52fcbcc and 62ee10f.

📒 Files selected for processing (2)
  • Dockerfile (1 hunks)
  • hivemind_etl/mediawiki/etl.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: ci / test / Test
  • GitHub Check: ci / lint / Lint
🔇 Additional comments (1)
hivemind_etl/mediawiki/etl.py (1)

97-106: Logging additions improve observability.

The new logging statements provide helpful runtime information and do not affect core logic. No issues found.

@amindadgar amindadgar merged commit d6e9aa5 into main Apr 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@amindadgar